Skip to content

Reduce size of generated code for lazy fields #5446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 15, 2018
Merged

Reduce size of generated code for lazy fields #5446

merged 1 commit into from
Nov 15, 2018

Conversation

allanrenucci
Copy link
Contributor

@allanrenucci allanrenucci commented Nov 15, 2018 •
edited
Loading

For lazy val x = <RHS>:

Before:

def x() =
  if (flag) target
  else {
    target = <RHS>
    flag = true
    target
  }

After:

def x() = {
  if (!flag) {
    target = <RHS>
    flag = true
  }
  target
}

@allanrenucci
Reduce size of generated code for lazy fields
236815b 
For `lazy val x = <RHS>`:

Before:
```
def x() =
  if (flag) target
  else {
    target = <RHS>
    flag = true
    target
  }
```

After:
```scala
def x() = {
  if(!flag) {
    target = <RHS>
    flag = true
  }
  target
}
```
@allanrenucci allanrenucci requested a review from smarter November 15, 2018 14:58
@allanrenucci allanrenucci merged commit 57f3efb into scala:master Nov 15, 2018
@allanrenucci allanrenucci deleted the lazy-vals branch November 15, 2018 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarter smarter smarter approved these changes

Assignees

@smarter smarter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@allanrenucci @smarter