Fix #5372: Use applyDynamic in structural calls
#5377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes how `Selectable` works for calling methods: It used to be called `selectMethodDynamic and to receive the name of the method to call along with the class tags of the formal parameters. This commit renames it to `applyDynamic`, and changes it so that it also takes the actual arguments that are passed in the function call. Fixes scala#5372
|
Nice, thank you! I'm especially pleased to see that it actually reduces complexity in |
odersky
approved these changes
Nov 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes how
Selectableworks for calling methods: It usedto be called `selectMethodDynamic and to receive the name of the method
to call along with the class tags of the formal parameters.
This commit renames it to
applyDynamic, and changes it so that it alsotakes the actual arguments that are passed in the function call.
Fixes #5372