Add back symbols to TASTy reflect #4976
Conversation
|
It's cool that exported symbols are compared by Another problem is that we still expose the internal details of desugaring of source definitions into definitions and symbols — objects create two symbols, case classes must create 1 for the class and two for the companion, etc. Those details might be appropriate for tasty reflection since it shows the typer output (tho @olafurpg has spent time hiding many such things), but only as long as they're things you'd be comfortable spec'ing — because that's what you are essentially doing even if you don't write that spec down. Details about e.g. enum are more concerning. |
| @@ -2,4 +2,4 @@ package dotty.tools.dotc.tastyreflect | |||
|
|
|||
| import dotty.tools.dotc.core._ | |||
|
|
|||
There was a problem hiding this comment.
Format the following line into several lines?
| @@ -2,4 +2,4 @@ package scala.tasty | |||
|
|
|||
| import scala.tasty.reflect._ | |||
|
|
|||
There was a problem hiding this comment.
Reformat the following line to be shorter?
| /** Tasty reflect symbol */ | ||
| trait SymbolOps extends TastyCore { | ||
|
|
||
| trait SymbolasAPI { |
There was a problem hiding this comment.
SymbolasAPI -> SymbolsAPI
| def localContext(implicit ctx: Context): Context | ||
| def tree(implicit ctx: Context): Option[Definition] | ||
| } | ||
| implicit def SymbolasDeco(symbol: Symbol): SymbolasAPI |
No description provided.