Change protected accessors #4597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New phase to check protected accessors. We now create accessors also for Scala symbols. Previously this was not done as it was assumed that such symbols will always be mapped to public. We create the accessors anyway in order to better test the functionality, so that we can at some point avoid the access widening from protected to public.
Protected accessor names are no longer pickled, but inline accessors are. Adapt name tags accordingly. Bump major Tasty version.
…classes Superaccessors handles this already correctly by generating a super accessor in this case.
Fix remaining problems, mostly having to do with choosing between super accessors and protected accessors.
allanrenucci
force-pushed
the
change-protected-accessors
branch
2 times, most recently
from
9015f02 to
fb31e4a
Compare
|
Allan, before we try to change this further, can we merge the status up to |
allanrenucci
force-pushed
the
change-protected-accessors
branch
from
cd51ffb to
bf62402
Compare
allanrenucci
commented
May 31, 2018
There was a problem hiding this comment.
LGTM (GitHub won't let me approve since I opened the PR). @smarter Do you want to have a quick look?
I'll move my commits to a separate PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopening #4568 that I closed by mistake