Make partial function literals serializable #4444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A more complex (and currently failing) test case can be found in #4446 |
allanrenucci
changed the title
smarter
reviewed
May 3, 2018
| @@ -111,8 +111,8 @@ class ExpandSAMs extends MiniPhase { | |||
| val isDefinedAtDef = transformFollowingDeep(DefDef(isDefinedAtFn, isDefinedAtRhs(_))) | |||
| val applyOrElseDef = transformFollowingDeep(DefDef(applyOrElseFn, applyOrElseRhs(_))) | |||
|
|
|||
| val parent = defn.AbstractPartialFunctionType.appliedTo(tpe.argInfos) | |||
| val anonCls = AnonClass(parent :: Nil, List(isDefinedAtFn, applyOrElseFn), List(nme.isDefinedAt, nme.applyOrElse)) | |||
| val parents = List(defn.AbstractPartialFunctionType.appliedTo(tpe.argInfos), defn.SerializableType) | |||
There was a problem hiding this comment.
Prefer JavaSerializableType over SerializableType (the latter should die in a fire but that hasn't happened yet: scala/bug#9080)
There was a problem hiding this comment.
OK I'll change. I used scala serializable because that's what scalac uses
There was a problem hiding this comment.
Hmm, maybe we should keep SerializableType for now and eventually replace them all at once.
smarter
approved these changes
May 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.