Fix #3415: Spurious clone failures in CI #3432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Duhemm
approved these changes
Nov 3, 2017
.drone.yml
Outdated
| - git init | ||
| - git remote add origin $DRONE_REMOTE_URL | ||
| - git fetch --no-tags origin $DRONE_COMMIT_REF | ||
| - if [ $DRONE_BUILD_EVENT == "push" ]; then git reset --hard -q $DRONE_COMMIT_SHA; else git checkout -qf FETCH_HEAD; fi |
There was a problem hiding this comment.
I think that the most portable way to compare strings in shell scripts is =.
This is a workaround for a bug where GitHub asks Drone to build a branch that does not exist yet. We simply sleep for 5s before cloning to make sure the branch is created
allanrenucci
force-pushed
the
fix-#3415
branch
from
cfc7ecd to
2554a0f
Compare
| - sleep 5s | ||
| - git init | ||
| - git remote add origin $DRONE_REMOTE_URL | ||
| - git fetch --no-tags origin $DRONE_COMMIT_REF |
There was a problem hiding this comment.
Are you sure this is the merged PR branch reference, as it was before?
There was a problem hiding this comment.
@nicolasstucki From the log:
+ git fetch --no-tags origin $DRONE_COMMIT_REF
From https://github.com/lampepfl/dotty
* branch refs/pull/3432/merge -> FETCH_HEAD
nicolasstucki
approved these changes
Nov 3, 2017
allanrenucci
added a commit
to dotty-staging/dotty
that referenced
this pull request
Nov 8, 2017
allanrenucci
added a commit
to dotty-staging/dotty
that referenced
this pull request
Nov 8, 2017
allanrenucci
added a commit
to dotty-staging/dotty
that referenced
this pull request
Nov 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround for a bug where GitHub asks Drone to build a branch
that does not exist yet. We simply sleep for 5s before cloning to make
sure the branch is created