Skip to content

Link directly to a JAR #3377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

nicolasstucki
Copy link
Contributor

No description provided.

@nicolasstucki nicolasstucki requested a review from smarter October 24, 2017 15:31
@smarter
Copy link
Member

smarter commented Oct 24, 2017

What's the motivation here?

@nicolasstucki
Copy link
Contributor Author

The motivation is to create a tool that given the classpath and an entry point, will link all classes that have a tasty. Later on optimizing them with the linker. The output is a jar to avoid overriding class files that may be in the output directory, making sure that the use of the tool is idempotent.

@smarter
Copy link
Member

smarter commented Oct 24, 2017

Why not use -d foo.jar to write classfiles directly to a jar instead of an output directory? I think scalac has this feature

@nicolasstucki
Copy link
Contributor Author

That was the intended effects thought I took a complicated solution. I will adapt it to the -d foo.jar scheme.

@nicolasstucki
Copy link
Contributor Author

I factored a part that handles JARs in #3382.

@nicolasstucki nicolasstucki force-pushed the link-to-jar branch 4 times, most recently from 36aa426 to 8da137b Compare October 25, 2017 15:35
@nicolasstucki nicolasstucki force-pushed the link-to-jar branch 8 times, most recently from aaf40df to 89daf0c Compare November 7, 2017 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants