Skip to content

Tune bench warmups #3088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 11, 2017
Merged

Tune bench warmups #3088

merged 2 commits into from
Sep 11, 2017

Conversation

nicolasstucki
Copy link
Contributor

No description provided.

var warmup = 30
var iterations = 20

if (intArgs.length > 0) warmup = intArgs(0).toInt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

val warmup = if (intArgs.length > 0) intArgs(0).toInt else 30

var iterations = 20

if (intArgs.length > 0) warmup = intArgs(0).toInt
if (intArgs.length > 1) iterations = intArgs(1).toInt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the CI failure looks spurious.

@nicolasstucki
Copy link
Contributor Author

nicolasstucki commented Sep 10, 2017

Yes, the CI failure was due to #2924, the fix is in #3080.

@liufengyun liufengyun merged commit ba94db9 into scala:master Sep 11, 2017
@liufengyun liufengyun deleted the tune-bench branch September 11, 2017 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants