Fix scripted empty-package test #2550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test started failing after we started emitting .tasty files by default in 1293e2f, because sbt will not by default delete these .tasty files when the corresponding .class file is deleted, which means that the directories containing these files are not deleted either. This is problematic because dotty creates package symbols based on the name of directories on the classpath, even if the directories contain no classfile. Thankfully, I already fixed this issue in sbt-dotty yesterday in 452bc5e, so all we need to do is make the scripted tests use the sbt-dotty plugin. This commit does this, and also move these tests to the sbt-dotty project since they depend on it now.
|
Merging now so that the nightly tests start working again. |
|
Great job! Thanks for doing this on a weekend! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test started failing after we started emitting .tasty files by
default in 1293e2f, because sbt will
not by default delete these .tasty files when the corresponding
.class file is deleted, which means that the directories containing
these files are not deleted either. This is problematic because dotty
creates package symbols based on the name of directories on the
classpath, even if the directories contain no classfile. Thankfully, I
already fixed this issue in sbt-dotty yesterday in
452bc5e, so all we need to do is make
the scripted tests use the sbt-dotty plugin. This commit does this, and
also move these tests to the sbt-dotty project since they depend on it now.