Fix #2063: Print tabs in message padding #2486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
reviewed
May 20, 2017
| @@ -101,9 +100,12 @@ trait MessageRendering { | |||
|
|
|||
| math.min(currPad, minPad) | |||
| } | |||
| val padding = | |||
| if (leastWhitespace - offset == pos.startColumn) pos.startColumnPadding | |||
| else " " * (leastWhitespace - offset) | |||
There was a problem hiding this comment.
I don't understand why this is correct. Why not use startColumnPadding in currPad above?
There was a problem hiding this comment.
Because we do not know the size of one tab.
There was a problem hiding this comment.
But indeed I need to modify the logic a bit
smarter
reviewed
May 20, 2017
| /** The padding of the column corresponding to `offset`, includes tabs */ | ||
| def startColumnPadding(offset: Int): String = { | ||
| var idx = startOfLine(offset) | ||
| val pad = new StringBuffer("") |
There was a problem hiding this comment.
Use StringBuilder instead to avoid the synchronization overhead of StringBuffer, also you can use the empty constructor: new StringBuilder
smarter
approved these changes
May 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.