chore: fix parameterless calls to functions #23204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamzaremmal
changed the title
hamzaremmal
commented
May 20, 2025
| @@ -245,7 +245,7 @@ class SettingsTests { | |||
| assertNotEquals(file1StateBefore, String(Files.readAllBytes(file1))) | |||
| assertEquals(file2StateBefore, String(Files.readAllBytes(file2))) | |||
|
|
|||
| }(Files.deleteIfExists(_), Files.deleteIfExists(_)) | |||
| }(using Files.deleteIfExists(_), Files.deleteIfExists(_)) | |||
There was a problem hiding this comment.
This was a warning, but we do not enable -Werror in the test. Unfortunately, this will change from implicit params to contextual params with the new library. Hence, I'm anticipating this error and I'm fixing it here.
hamzaremmal
force-pushed
the
drop-illegal-code
branch
from
0011ae9 to
8fa6145
Compare
sjrd
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to parameterless/empty parameter list such that the code follows the specification.
NOTE: This code shouldn't have compiled in the first place. I'm raising an issue as soon as I finish what I'm focusing on.