Skip to content

Fix #2279: Use concurrent data structures in SummaryReport. #2298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2017

Conversation

nicolasstucki
Copy link
Contributor

No description provided.

@felixmulder
Copy link
Contributor

Are you sure this fixes the issue? I'd like to have seen a thread dump with the original issue.

@nicolasstucki
Copy link
Contributor Author

I haven't been able to reproduce and the dump at the moment where a concurrent update breaks the coherency on the ArrayBuffer. But I got the following array after adding cleanups with append.

screen shot 2017-04-24 at 13 57 50

Where the implementation of append is:

def +=(elem: A): this.type = {
  ensureSize(size0 + 1)
  array(size0) = elem.asInstanceOf[AnyRef]
  size0 += 1
  this
}

@felixmulder felixmulder merged commit 01e172b into scala:master Apr 25, 2017
@allanrenucci allanrenucci deleted the fix-#2279 branch December 14, 2017 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants