Skip to content

Rename on import is never wildcard #22712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2025
Merged

Rename on import is never wildcard #22712

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion compiler/src/dotty/tools/dotc/transform/CheckUnused.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,8 +284,11 @@ class CheckUnused private (phaseMode: PhaseMode, suffix: String) extends MiniPha
case sel :: sels =>
val matches =
if sel.isWildcard then
// if name is different from sym.name, it must be a rename on import, not a wildcard selector
!name.exists(_.toTermName != sym.name.toTermName)
// the qualifier must have the target symbol as a member
hasAltMember(sym.name) && {
&& hasAltMember(sym.name)
&& {
if sel.isGiven then // Further check that the symbol is a given or implicit and conforms to the bound
sym.isOneOf(GivenOrImplicit)
&& (sel.bound.isEmpty || sym.info.finalResultType <:< sel.boundTpe)
Expand Down
7 changes: 7 additions & 0 deletions tests/warn/i15503a.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,3 +321,10 @@ object Suppressed:
object Suppressing:
import Suppressed.* // no warn, see options
def f = 42

package i22692:
import javax.swing.*
import javax.swing.event as swingEvent // no warn, regression test for warning in 3.6

type b = AbstractButton
type t = swingEvent.AncestorListener
Loading