Fix CI workflows for publishing releases. #21789
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ld-sdk-package. Store .sha256 for each of the files, instead of creating sha256.txt with shas for reach directory to ease validatation
WojciechMazur
force-pushed
the
fix/ci-publish_release
branch
from
e11abb9 to
a472087
Compare
hamzaremmal
approved these changes
Oct 17, 2024
WojciechMazur
added a commit
that referenced
this pull request
Oct 17, 2024
Reuse SDKs generated in `build-sdk-package` job. Store .sha256 for each of the files, instead of creating sha256.txt with shas for the reach directory to ease validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reuse SDKs generated in
build-sdk-packagejob.Store .sha256 for each of the files, instead of creating sha256.txt with shas for the reach directory to ease validation. eg. now instead of having
sha256.txt, we would have a set of files:scala-3.6.0.zipscala-3.6.0.zip.sha256scala-3.6.0-tar.gzscala-3.6.0-tar.gz.sha256The same applies to all native distributions but with additional suffixes, eg.
scala-3.6.0-x86_64-pc-linux.zip.sha256.By having an SHA file containing only a single digest it should be much easier to verify the correctness of the downloaded file. Additionally, by keeping consistent names between the archive file and its zip file it's easier to find expected SHA. The approach is partially based on Bazel way of publishing artefacts.
Required to unblock the 3.6.0-RC1 release https://github.com/scala/scala3/actions/runs/11365076845