Transform/private to static #207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import ast.Trees._ | ||
| import TreeTransforms.TransformerInfo | ||
|
|
||
| /** The preceding lambda lift and flatten phases move symbols to different scopes |
There was a problem hiding this comment.
The comment doesn't match the phase
|
Otherwise LGTM. |
Some changes needed so that Flatten can run after LambdaLift
To be combinable with follow-up mini-phases the lift operation needs to handle Thickets specially. This commit factors out the behavior from LambdaLift, so that Flatten can do the same thing.
Cleans up after LambdaLift and Flatten. RestoreScopes exhibited a problem (double definition) when compiling Unpickler. The root of the problem was in Applications.scala. The effect was that arguments woulkd be lifted out, but then the argument expression would be used anyway. That caused a closure to be present twice which caused the double def error much later. -Ycheck did not catch it because the two closure expressions were in non-overlapping scopes.
Threw away list of constructed statements.
Make private methods in traits static, so that we do not need to give a default for them.
odersky
force-pushed
the
transform/privateToStatic
branch
from
f73772b to
74ec188
Compare
|
Force pushed after rebase to current master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New miniphase. Builds on #203.
I wanted to merge with previous but need some functionality in TreeTransforms to do it.
Review by @DarkDimius