Skip to content

Fix #1908: give synthetic default params correct flags #1910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2017
Merged

Fix #1908: give synthetic default params correct flags #1910

merged 1 commit into from
Jan 28, 2017

Conversation

felixmulder
Copy link
Contributor

It turned out that it was only methods with default parameters that were missing the synthetic flag.

@felixmulder felixmulder requested a review from odersky January 25, 2017 13:47
odersky
odersky approved these changes Jan 28, 2017
View reviewed changes
Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felixmulder felixmulder merged commit 494aee2 into scala:master Jan 28, 2017
@felixmulder felixmulder deleted the fix/#1908-synthetic-desugarings branch January 28, 2017 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odersky odersky odersky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felixmulder @odersky