Use BitSet for boolean TASTy attributes
#19092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
tasty-attributes-bitset
branch
from
4803bb9 to
96bea13
Compare
bishabosha
approved these changes
Nov 27, 2023
bishabosha
reviewed
Nov 27, 2023
| new Attributes(booleanTags.result()) | ||
| end apply | ||
|
|
||
| def empty: Attributes = |
There was a problem hiding this comment.
maybe this should be a val? - we will probably read a lot of old tasty that doesnt have the attributes section
There was a problem hiding this comment.
Added a commit with this change
bishabosha
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.