Refactor MacroAnnotations.callMacro #18581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move error handling into call macro This method should handle the reflective calls and their errors.
hamzaremmal
approved these changes
Oct 10, 2023
There was a problem hiding this comment.
LGTM! On another note, shouldn't we also add a call to filter before the foldLeft in line 51. I don't think it would be that different from a performance point of view and we can also get rid of the bit if-else expression. If yes, should we do this on another PR ?
We could do that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move error handling into call macro This method should handle the reflective calls and their errors.