Skip to content

Fix missing case in isSubspace, which broke reachablility #18326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 3, 2023
Merged

Fix missing case in isSubspace, which broke reachablility #18326

merged 1 commit into from
Aug 3, 2023

Conversation

dwijnand
Copy link
Member

@dwijnand dwijnand commented Aug 2, 2023

No description provided.

@dwijnand dwijnand linked an issue Aug 2, 2023 that may be closed by this pull request
Missing unreachable case warning #18118
Closed
@dwijnand dwijnand requested a review from liufengyun August 3, 2023 08:39
@dwijnand dwijnand marked this pull request as ready for review August 3, 2023 08:39
liufengyun
liufengyun approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dwijnand dwijnand merged commit 6a6ee08 into scala:main Aug 3, 2023
@dwijnand dwijnand deleted the unreachable-single-child branch August 3, 2023 17:41
@Kordyjan Kordyjan added this to the 3.4.0 milestone Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liufengyun liufengyun liufengyun approved these changes

Assignees

@liufengyun liufengyun

Labels
None yet
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.

Missing unreachable case warning
3 participants
@dwijnand @liufengyun @Kordyjan