Fix inferred result types of non private members in stdlib-bootstapped #17975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
stdlib-add-explicit-result-to-non-private-members
branch
from
c287511 to
8d7bbfa
Compare
nicolasstucki
force-pushed
the
stdlib-add-explicit-result-to-non-private-members
branch
from
e83d7d0 to
53d326a
Compare
|
@nicolasstucki should we remove the skips now and force CI to rerun? |
nicolasstucki
force-pushed
the
stdlib-add-explicit-result-to-non-private-members
branch
from
fb9d723 to
26d1d8f
Compare
nicolasstucki
force-pushed
the
stdlib-add-explicit-result-to-non-private-members
branch
from
26d1d8f to
66b05b8
Compare
dwijnand
approved these changes
Jun 15, 2023
nicolasstucki
deleted the
stdlib-add-explicit-result-to-non-private-members
branch
nicolasstucki
added a commit
to nicolasstucki/scala
that referenced
this pull request
Jun 16, 2023
Add explicit result type to methods where Scala 2 and Scala 3 disagree with the inferred type. The aim is to have the same type in the Scala 2 pickles and the Scala 3 TASTy. These where identified in scala/scala3#17975
nicolasstucki
added a commit
to nicolasstucki/scala
that referenced
this pull request
Jun 16, 2023
Add explicit result type to methods where Scala 2 and Scala 3 disagree with the inferred type. The aim is to have the same type in the Scala 2 pickles and the Scala 3 TASTy. These where identified in scala/scala3#17975
nicolasstucki
added a commit
to nicolasstucki/scala
that referenced
this pull request
Jun 21, 2023
Add explicit result type to methods where Scala 2 and Scala 3 disagree with the inferred type. The aim is to have the same type in the Scala 2 pickles and the Scala 3 TASTy. These where identified in scala/scala3#17975
nicolasstucki
added a commit
to nicolasstucki/scala
that referenced
this pull request
Jun 26, 2023
Add explicit result type to methods where Scala 2 and Scala 3 disagree with the inferred type. The aim is to have the same type in the Scala 2 pickles and the Scala 3 TASTy. Follow up of scala#10435 These where identified in and tested in * scala/scala3#18032 * scala/scala3#18029 * scala/scala3#17975 (BitSet)
hamzaremmal
pushed a commit
to hamzaremmal/scala3
that referenced
this pull request
May 2, 2025
Add explicit result type to methods where Scala 2 and Scala 3 disagree with the inferred type. The aim is to have the same type in the Scala 2 pickles and the Scala 3 TASTy. These where identified in scala#17975
hamzaremmal
pushed a commit
to hamzaremmal/scala3
that referenced
this pull request
May 2, 2025
Add explicit result type to methods where Scala 2 and Scala 3 disagree with the inferred type. The aim is to have the same type in the Scala 2 pickles and the Scala 3 TASTy. Follow up of scala/scala#10435 These where identified in and tested in * scala#18032 * scala#18029 * scala#17975 (BitSet)
hamzaremmal
pushed a commit
that referenced
this pull request
May 7, 2025
Add explicit result type to methods where Scala 2 and Scala 3 disagree with the inferred type. The aim is to have the same type in the Scala 2 pickles and the Scala 3 TASTy. These where identified in #17975
hamzaremmal
pushed a commit
that referenced
this pull request
May 7, 2025
Add explicit result type to methods where Scala 2 and Scala 3 disagree with the inferred type. The aim is to have the same type in the Scala 2 pickles and the Scala 3 TASTy. Follow up of scala/scala#10435 These where identified in and tested in * #18032 * #18029 * #17975 (BitSet)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cloned original Scala 2 sources (in commits
Clone ...) and added explicit result types to methods where Scala 2 and Scala 3 infer different types (in commitsFix ...).Once accepted, I will open a PR to
scala/scalato add these missing signatures directly to the library.I used
stdlib-boostrapped/run clone scala/XYZ.scalato clone the sources.