Reword error messages in initialization checker to be more user friendly. #17030
Conversation
| @@ -470,7 +472,7 @@ object Semantic: | |||
| def widenArg: Contextual[Value] = | |||
| a match | |||
| case _: Ref | _: Fun => | |||
| val hasError = Reporter.hasErrors { a.promote("Argument cannot be promoted to hot") } | |||
| val hasError = Reporter.hasErrors { a.promote("Argument cannot be promoted to transitively initialized (Hot)") } | |||
There was a problem hiding this comment.
@liufengyun Should we consider saying something like "proven" instead of "promoted"? e.g. "Argument cannot be proven to be transitively initialized"
There was a problem hiding this comment.
In the documentation, we say "promotion" and have a definition for it. It seems to me "prove" is better than "promoted". We can see if we can change the definition in the docs as well --- something like "provably hot".
tests/init/neg/default-this.check
Outdated
| | ^ | ||
| | -> compare() // error [ default-this.scala:9 ] | ||
| | ^^^^^^^ | ||
| |Could not verify that the method argument is transitively initialized (Hot). It was found to be the original object of type "class B" that started this trace. Only transitively initialized arguments may be passed to methods outside the analyzed initialization region. |
There was a problem hiding this comment.
This one is problematic because the method doesn't take any arguments. Is the error about the receiver of the method?
There was a problem hiding this comment.
The function signature is def compare(c: Int = 5, a: A = this): Boolean. It could possibly be referring to the default A argument.
Rewords some warning messages produced by the -Ysafe-init flag so that they are better understood by the user.
Addresses Issue #15836