Refactor init checker: Extract reusable code #16705
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liufengyun
force-pushed
the
refactor-init
branch
from
bd03307 to
408bec3
Compare
olhotak
reviewed
Jan 18, 2023
| * | ||
| * `changed == false` implies that the fixed point has been reached. | ||
| */ | ||
| protected var changed: Boolean = false |
There was a problem hiding this comment.
Is changed part of the cache? Is the heap now intended to be independent of the cache? Should changed and hasChanged be renamed to indicate that they are about the heap?
There was a problem hiding this comment.
Yes, changed is part of the cache, it's not related to the heap.
liufengyun
force-pushed
the
refactor-init
branch
from
7faa4bf to
464fa5d
Compare
olhotak
approved these changes
Jan 29, 2023
| * cache.last = cache.current | ||
| * cache.current = Empty | ||
| * cache.changed = false | ||
| * iterate(outputCache, emptyCache) |
There was a problem hiding this comment.
If iterate is a recursive call to def iterate above, then def iterate should have these two explicit parameters.
There was a problem hiding this comment.
That's changed in the last commit.
There was a problem hiding this comment.
Oh, sorry, yes, you're right.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor init checker: Extract reusable code