Skip to content

Revive tests for sbt-bridge #16659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Revive tests for sbt-bridge #16659

merged 1 commit into from
Jan 11, 2023

Conversation

prolativ
Copy link
Contributor

  • reuseCompilerInstance option was removed, as now, when we trigger compilation directly via the bridge, a new instance of the compiler is created for each group of sources. However, it looks like this previously available distinction was never used effectively
  • objectStandardNames in expected test results were removed because now the fact that all objects extend Serializable is not visible in the typer but added during bytecode generation

Copy link
Member

@smarter smarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@smarter smarter merged commit a9be390 into scala:main Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants