Upgrade to Scala.js 1.11.0 then 1.12.0. #16411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Port of the compiler and build changes from the following commits: * scala-js/scala-js@b7e7c56 * scala-js/scala-js@cb80afb * scala-js/scala-js@994a598 * scala-js/scala-js@d6fe1a8 * scala-js/scala-js@bcce3f2 * scala-js/scala-js@b1137d5 * scala-js/scala-js@874d9b9 * scala-js/scala-js@3fb2b96 In addition, we have to update the compiler test infrastructure to include the new `scalajs-javalib` artifact. Unfortunately, there is an unchecked val extraction in the source code of scalajs-ir. We temporarily disable fatal warnings in the compiler, until we can upgrade to Scala.js 1.12.0.
|
Spire did not like it, for some reason :s |
We omit in this commit the upstream changes to add support for `@JSOperator`, from the PR scala-js/scala-js#4744 Doing so does not prevent the test suite from passing at the moment. We leave them for an upcoming PR.
|
I ignored on test in Spire for Scala.js. See commit message and comment within the spire submodule. |
nicolasstucki
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.