Universal bisect script #16398
Merged
Universal bisect script #16398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prolativ
force-pushed
the
universal-bisect
branch
from
19ad5dc to
779ef7d
Compare
nicolasstucki
previously requested changes
Nov 25, 2022
prolativ
force-pushed
the
universal-bisect
branch
2 times, most recently
from
02b9083 to
2e0152a
Compare
* Use locally published versions of scala when bisecting commits to unify validation of commits and published nightly versions * Validate compiler versions using custom scripts - e.g scala-cli and/or expect can be used
prolativ
force-pushed
the
universal-bisect
branch
from
2e0152a to
cdb31bc
Compare
|
I tried bisecting some issues with the new script and it turns out that we need to publish locally bootstrapped versions of the compiler to get correct results in some cases, even though this makes bisecting commits slower. So I updated the script accordingly |
|
@nicolasstucki does this thumb up mean an actual approve? |
|
It means I approve publishing the bootstrapped compiler. I also saw that this was necessary. In practice, this is not too long given that we prone the commits extremely fast with the nightly builds. |
nicolasstucki
approved these changes
Nov 28, 2022
KacperFKorban
approved these changes
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve bisect script: