[Backport] Support Mirrors for local and inner classes. #15874
Conversation
- update child accessibility check for anonymous mirrors in whyNotGenericSum. Now check the prefix at the callsite can access the child. - for sum mirrors, compute a new prefix for each child from the callsite prefix of the parent, see TypeOps.childPrefix. For each child, subsititute its prefix at definition with the childPrefix using asSeenFrom. For polymorphic classes, perform the subsitution on the constructor before inferring constraints. - add tests for issues 13332, 13935, 11174, 12328 - add tests for local/inner classes taken from Shapeless for its Generic type, backed by mirrors document mirror changes
bishabosha
changed the title
|
@bishabosha Are we 100% sure that it cannot break any existing code? If we are not sure then I would prefer to run a full community build with that change before the release. |
|
@Kordyjan I am not aware of thew what the process and requirements to merge this are, all I know is that 3.2.0 code will not be able to depend on 3.2.1 code. The original PR didn't break dotty's community build |
|
Ok, I understand it now after reading the original PR. We indeed need this to be released with 3.2.0. So the easiest for us would be to merge it now, then release it with 3.2.0-RC4 and then run the full community build (the one with over 900 projects). If it detects something we will either try to mitigate that somehow and release another RC or just declare we are introducing another breaking change in 3.2. |
|
test performance please |
1 similar comment
|
test performance please |
|
performance test scheduled: 10 job(s) in queue, 2 running. |
|
performance test failed: Please check https://dotty-bench.epfl.ch/logs/ for more information |
backports #15847 because otherwise it is a forward source breaking change from 3.2.0 to 3.2.1
recommended by @sjrd