Execute tests/run/ tests with Scala.js. #15543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjrd
force-pushed
the
sjs-vulpix-run-tests
branch
2 times, most recently
from
1978640 to
4a8d1fa
Compare
We add support for skipping tests based on "toolArgs" flags, written in the test sources as // scalajs: --skip The `ScalaJSCompilationTests` takes the `scalajs` toolArgs into account, while the JVM `CompilationTests` do not. This effectively means that tests marked as above are run only on the JVM. Good reasons for being skipped on Scala.js include: * Using `.java` source files. * Using Java reflection (sometimes to implement the testing logic, more than what gets tested). * Relying on `NullPointerException`s being thrown. * Testing the precise result of `getClass()` of `classOf`, which is not the same for `BoxedUnit` in Scala.js (these cases are extensively tested in Scala.js' own test suite, so they are well covered). Some tests are skipped for less good reasons, for example: * The `Course-*` tests are long, ancient tests that don't test anything in particular, but rely a lot on the precise printed form of Doubles. Some tests rely on what Scala.js calls "compliant semantics". They receive the flag `--compliant-semantics` to instruct the Scala.js linker to enable them. Many tests, due to the `println`-based nature of Vulpix, rely on the precise printed form of `Double`s and `Unit`s. When reasonably practical, these have been amended to pass one way or another on Scala.js: * using non-whole `Double`s, or * explicitly trimming trailing `.0` from the string representation of doubles, or * explicitly converting `()` to `"()"`, or * using other data types, or * printing `Double`s instead of `Float`s, or * avoiding to print irrelevant details. Tests that are supposed to pass, but do not because of what seems to be a bug, are marked // scalajs: --skip --pending so that we can grep for them later and try to fix them.
sjrd
force-pushed
the
sjs-vulpix-run-tests
branch
from
4a8d1fa to
3518226
Compare
|
@dwijnand May I give you this one? |
|
Should we merge this before it grows stale? Any objection? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add support for skipping tests based on "toolArgs" flags, written in the test sources as
// scalajs: --skipThe
ScalaJSCompilationTeststakes thescalajstoolArgs into account, while the JVMCompilationTestsdo not. This effectively means that tests marked as above are run only on the JVM.Good reasons for being skipped on Scala.js include:
.javasource files.NullPointerExceptions being thrown.getClass()ofclassOf, which is not the same forBoxedUnitin Scala.js (these cases are extensively tested in Scala.js' own test suite, so they are well covered).Some tests are skipped for less good reasons, for example:
Course-*tests are long, ancient tests that don't test anything in particular, but rely a lot on the precise printed form of Doubles.Some tests rely on what Scala.js calls "compliant semantics". They receive the flag
--compliant-semanticsto instruct the Scala.js linker to enable them.Many tests, due to the
println-based nature of Vulpix, rely on the precise printed form ofDoubles andUnits. When reasonably practical, these have been amended to pass one way or another on Scala.js:Doubles, or.0from the string representation of doubles, or()to"()", orDoubles instead ofFloats, orTests that are supposed to pass, but do not because of what seems to be a bug, are marked
// scalajs: --skip --pendingso that we can grep for them later and try to fix them.