Refactor inliner #15528
Merged
Refactor inliner #15528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odersky
force-pushed
the
refactor-inliner
branch
from
52c46d8 to
a3f3c28
Compare
nicolasstucki
approved these changes
Jun 28, 2022
Inliner has become a bit of a ball of mud. It was over 2000 lines and handled several aspects that did not have clear boundaries. This commit refactors Inliner into three units in a new package `inlines`. They are: - Inlines.scala: The frontend for querying inline methods and issuing inline calls. - Inliner.scala: This unit does the main job of inlining. It transforms a call with a given right hand side into a list of bindings and an expansion. - InlineReducer.scala: A helper class used by Inliner that does rewriting of inlined code with the aim of optimizing it. The three units are joined by `PrepareInlineable` in package `inlines`.
odersky
force-pushed
the
refactor-inliner
branch
from
db594cb to
c6d297b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inliner has become a bit of a ball of mud. It was over 2000 lines and handled several aspects that
did not have clear boundaries. This commit refactors Inliner into three units in a new package
inlines.They are:
a given right hand side into a list of bindings and an expansion.
with the aim of optimizing it.
The three units are joined by
PrepareInlineablein packageinlines.