Allow for unqualified apply as context functions
#15417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
requested changes
Jun 10, 2022
|
@smarter Yes, good suggestion. |
|
Actually even better would be to use tpd.qualifier to handle the match: https://github.com/lampepfl/dotty/blob/9614fb9ce148e184d40948060904d0b1bd713ec0/compiler/src/dotty/tools/dotc/ast/TreeInfo.scala#L854-L861 |
smarter
approved these changes
Jun 10, 2022
|
We now don't allow single apply's to be used as constructor proxies The previous commits allowed them but that caused runtime errors in Specs2 since Since this is a weird corner case it's better not to allow it. As long as we do The error message we get now is: which is also a bit strange, but since this is a truly weird corner case it's not worth it |
smarter
approved these changes
Jun 11, 2022
The previous commits allowed them but that caused runtime errors in Specs2 since
`apply` was bound to something different from before.
Since this is a weird corner case it's better not to allow it. As long as we do
not crash we are good.
The error message we get now is:
constructor proxy `apply` cannot be used as a value
which is also a bit strange, but since this is a truly weird corner case it's not worth it
to finetune this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15414