Simplify lubs in TreeUnpickler #15105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A difference between Typer and TreeUnpickler is that Typer performs a simplification step after type assigning a tree mode and unpickler doesn't. This makes a difference for lubs in unsafeNulls mode. We fix this by also doing simplification in Unpickler for trees that can have types resulting from lubs.
I was not able to find out why that's the case, but the original test case with the import in the function body requires that if's are _not_ simplified by Unpickler. The interaction with lubs and unsafenulls seems to be very tricky. Anyway, we now have two versions of all test cases, with local as well as globak unsafe nulls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A difference between Typer and TreeUnpickler is that Typer performs
a simplification step after type assigning a tree mode and unpickler
doesn't. This makes a difference for lubs in unsafeNulls mode.
We fix this by also doing simplification in Unpickler for trees
that can have types resulting from lubs.