Skip to content

Upgrade to Scala.js 1.9.0. #14610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 7, 2022
Merged

Conversation

sjrd
Copy link
Member

@sjrd sjrd commented Mar 2, 2022

This includes a forward-port of the upstream changes in

sjrd added 2 commits March 2, 2022 14:49
For the upcoming forward-incompatible changes.
This includes a forward-port of the upstream changes in

* scala-js/scala-js@887d957
  Require an explicit name in @jsglobal for 'apply' and setter names.
* scala-js/scala-js@354cfdf
  Allow @jsglobal without explicit names inside Scala objects.
* scala-js/scala-js@9fa6a83
  Fix scala#4069: Make @jsimport's second arg default to the annotatee's name.
@sjrd sjrd added area:scala.js needs-minor-release This PR cannot be merged until the next minor release labels Mar 2, 2022
@sjrd sjrd added this to the 3.2.0-RC1 milestone Mar 2, 2022
@sjrd sjrd requested a review from nicolasstucki March 2, 2022 15:25
@nicolasstucki nicolasstucki merged commit 1080f1b into scala:main Mar 7, 2022
@nicolasstucki nicolasstucki deleted the scalajs-1.9.0 branch March 7, 2022 08:48
@smarter
Copy link
Member

smarter commented Mar 7, 2022

It's not clear to me that the next release should be 3.2.0, we're supposed to release in a few days and we haven't had time to go through all experimental APIs, and I don't think we should rush it now, so I think we should revert this until 3.1.3-RC1 is out in a few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:scala.js needs-minor-release This PR cannot be merged until the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants