Handle trailing commas in parser instead of scanner #14517
There are no files selected for viewing
Submodule specs2
updated
1 files
| +1 −1 | core/shared/src/main/scala/org/specs2/matcher/ActionMatchers.scala |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| -- [E040] Syntax Error: tests/neg/comma-separated-errors.scala:3:21 ---------------------------------------------------- | ||
| 3 | def foo(x: Int = 5 6, y Int = 7, z: Int 5, x = 5): Unit = () // error // error // error // error | ||
| | ^ | ||
| | ')' expected, but integer literal found | ||
| -- [E040] Syntax Error: tests/neg/comma-separated-errors.scala:3:26 ---------------------------------------------------- | ||
| 3 | def foo(x: Int = 5 6, y Int = 7, z: Int 5, x = 5): Unit = () // error // error // error // error | ||
| | ^^^ | ||
| | ':' expected, but identifier found | ||
| -- [E040] Syntax Error: tests/neg/comma-separated-errors.scala:3:42 ---------------------------------------------------- | ||
| 3 | def foo(x: Int = 5 6, y Int = 7, z: Int 5, x = 5): Unit = () // error // error // error // error | ||
| | ^ | ||
| | ')' expected, but integer literal found | ||
| -- [E040] Syntax Error: tests/neg/comma-separated-errors.scala:3:47 ---------------------------------------------------- | ||
| 3 | def foo(x: Int = 5 6, y Int = 7, z: Int 5, x = 5): Unit = () // error // error // error // error | ||
| | ^ | ||
| | ':' expected, but '=' found | ||
| -- [E040] Syntax Error: tests/neg/comma-separated-errors.scala:11:16 --------------------------------------------------- | ||
| 11 | case Plus(4 1) => // error | ||
| | ^ | ||
| | ')' expected, but integer literal found | ||
| -- [E040] Syntax Error: tests/neg/comma-separated-errors.scala:12:16 --------------------------------------------------- | ||
| 12 | case Plus(4 5 6 7, 1, 2 3) => // error // error | ||
| | ^ | ||
| | ')' expected, but integer literal found | ||
| -- [E040] Syntax Error: tests/neg/comma-separated-errors.scala:12:28 --------------------------------------------------- | ||
| 12 | case Plus(4 5 6 7, 1, 2 3) => // error // error | ||
| | ^ | ||
| | ')' expected, but integer literal found | ||
| -- [E040] Syntax Error: tests/neg/comma-separated-errors.scala:14:12 --------------------------------------------------- | ||
| 14 | val x: A[T=Int, T=Int] = ??? // error // error | ||
| | ^ | ||
| | ']' expected, but '=' found | ||
| -- [E040] Syntax Error: tests/neg/comma-separated-errors.scala:14:19 --------------------------------------------------- | ||
| 14 | val x: A[T=Int, T=Int] = ??? // error // error | ||
| | ^ | ||
| | ']' expected, but '=' found |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| class A[T] | ||
| object o { | ||
| def foo(x: Int = 5 6, y Int = 7, z: Int 5, x = 5): Unit = () // error // error // error // error | ||
|
|
||
| case class Plus(a: Int, b: Int) | ||
|
|
||
| object Plus { | ||
| def unapply(r: Int): Plus = Plus(r - 1, 1) | ||
| } | ||
| 5 match { | ||
| case Plus(4 1) => // error | ||
| case Plus(4 5 6 7, 1, 2 3) => // error // error | ||
| } | ||
| val x: A[T=Int, T=Int] = ??? // error // error | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| class A[T] | ||
| object o { | ||
| // Testing compiler crash, this test should be modified when named type argument are completely implemented | ||
| val x: A[T=Int, T=Int] = ??? // error: ']' expected, but '=' found // error: ']' expected, but '=' found | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Main change here, this is moved out of the scanner, but here we no longer have to guess what lookahead token might indicate a trailing comma.