Skip redundant superclasses\supertraits. #1368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
skip-redundant-superclasses
branch
7 times, most recently
from
20bdf40 to
61325d1
Compare
|
Review by @DarkDimius |
| import dotty.tools.dotc.core.Symbols._ | ||
| import dotty.tools.dotc.transform.TreeTransforms.{MiniPhaseTransform, TransformerInfo} | ||
|
|
||
| class CollectSuperCalls extends MiniPhaseTransform { |
There was a problem hiding this comment.
Please add a comment explaining what the purpose of this phase is in some details
There was a problem hiding this comment.
I knew that I was missing something important but could not remember what.
nicolasstucki
force-pushed
the
skip-redundant-superclasses
branch
from
61325d1 to
468ff9c
Compare
nicolasstucki
changed the title
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.