Discard reporter output for tests that succeed. #1360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
junit-discard-output
branch
from
7e3aeca to
6caffc0
Compare
| if (reporter == null) { | ||
| consoleReporter.doReport(d) | ||
| } else { | ||
| reporter.doReport(d) |
There was a problem hiding this comment.
why not wait until test finished and then if (reporter.hasErrors) reporter.flush?
There was a problem hiding this comment.
Because I do not have access to the context here.
nicolasstucki
force-pushed
the
junit-discard-output
branch
from
6caffc0 to
fc09686
Compare
| if (innerStoreReporter == null) { | ||
| consoleReporter.report(d) | ||
| } else { | ||
| innerStoreReporter.report(d) |
There was a problem hiding this comment.
Since last update I changed .doReport(d) with .report(d).
nicolasstucki
force-pushed
the
junit-discard-output
branch
2 times, most recently
from
e871021 to
abf258e
Compare
|
For the |
|
LGTM |
nicolasstucki
force-pushed
the
junit-discard-output
branch
from
abf258e to
1b4511b
Compare
nicolasstucki
changed the title
|
Just changed the commit message |
nicolasstucki
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.