Skip to content

fix #13332: change accessibility in whyNotGenericSum #13393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix #13332: change accessibility in whyNotGenericSum #13393

wants to merge 1 commit into from

Conversation

bishabosha
Copy link
Member

change to use isAccessibleFrom

fixes #13332

@bishabosha bishabosha requested a review from odersky August 26, 2021 13:21
@bishabosha bishabosha added this to the 3.1.0 milestone Aug 26, 2021
@nicolasstucki nicolasstucki assigned bishabosha and unassigned odersky Aug 26, 2021
@nicolasstucki
Copy link
Contributor

@bishabosha tests failed

dwijnand
dwijnand approved these changes Aug 27, 2021
View reviewed changes
Copy link
Member

@dwijnand dwijnand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't tell if this is allowing false negatives, but it looks like a reasonable change to make the case work.

@bishabosha
Copy link
Member Author

bishabosha commented Aug 27, 2021 •
edited
Loading

Can't tell if this is allowing false negatives, but it looks like a reasonable change to make the case work.

I will add more test cases

@bishabosha bishabosha marked this pull request as draft August 27, 2021 08:17
@bishabosha
Copy link
Member Author

bishabosha commented Aug 27, 2021 •
edited
Loading

to solve #13332 needs more than an accessibility test, it also affects code generation as the prefix of the outer class needs to be substituted wherever it can appear, see comment #13332 (comment)

I will see what I can do today

@bishabosha bishabosha removed this from the 3.1.0 milestone Aug 27, 2021
@bishabosha
Copy link
Member Author

I don't think this can be solved before Monday

@bishabosha bishabosha added this to the 3.1.0 milestone Aug 27, 2021
@dwijnand
Copy link
Member

image

🤔

@bishabosha
Copy link
Member Author

bishabosha commented Aug 30, 2021 •
edited
Loading

🤔

I'll see what I can do today - but I imagine reviewing would not meet the deadline, so perhaps I should remove again

@odersky
Copy link
Contributor

odersky commented Aug 30, 2021

I'll see what I can do today - but I imagine reviewing would not meet the deadline, so perhaps I should remove again

Even if it could be reviewed it should wait IMO. Big changes in functionality should be tested in nightlies for an extended period of time before being rolled into a release.

@odersky odersky removed this from the 3.1.0 milestone Aug 30, 2021
@bishabosha
Copy link
Member Author

closing this in favor of a new approach

@bishabosha bishabosha closed this Sep 3, 2021
@bishabosha bishabosha deleted the fix-13332 branch September 10, 2021 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwijnand dwijnand dwijnand approved these changes

@odersky odersky Awaiting requested review from odersky

Assignees

@bishabosha bishabosha

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Summoning Mirror for ADT defined in trait
4 participants
@bishabosha @nicolasstucki @dwijnand @odersky