Handle type alias in capturing wildcards #13260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liufengyun
reviewed
Aug 6, 2021
We extend capturing wildcards so that it operates on the type after dealiasing. However, in line with, for example, derivedRefinedType, we want to return the original type if nothing was captured, because it's on that basis that adapt decides whether it needs to cast and re-adapt to the new type with the type boxes. Co-authored-by: Seth Tisue <[email protected]>
dwijnand
force-pushed
the
wildcards-be-wild
branch
from
d1b9a01 to
e0622ea
Compare
liufengyun
approved these changes
Aug 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We extend capturing wildcards so that it operates on the type after
dealiasing. However, in line with, for example, derivedRefinedType, we
want to return the original type if nothing was captured, because it's
on that basis that adapt decides whether it needs to cast and re-adapt
to the new type with the type boxes.
Fixes #12739