Fix "is not a trait" when extending a Java annotation #13225
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Java annotations are interfaces ("@interface Foo") but we model them as
classes to mimic Scala annotations and avoid special-casing. So we add
some special-casing in Namer for the not-actually-classes Java
annotations.
smarter
reviewed
Jul 31, 2021
Was there some fundamental issue with this approach? |
|
No, just toppled the gain/effort balance for me so I dropped it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Java annotations are interfaces ("@interface Foo") but we model them as classes to mimic Scala annotations and avoid special-casing. So we add some special-casing in Namer for the not-actually-classes Java annotations.
Also fix "Invalid interfaces" when constructing a annotation subclass
Fixes #12840
I took a bit of a stab at what fixed the two reported cases, so let me know if things should be done differently.