Use sbt makeScalaInstance #12771
Use sbt makeScalaInstance #12771
Conversation
| ): ScalaInstance = { | ||
| val cache = state.extendedClassLoaderCache | ||
|
|
||
| val fullLoader = cache(docJars.toList, base.loaderCompilerOnly) |
There was a problem hiding this comment.
This version reused the classloader from base for compiler and library jars, whereas the new one will recreate it it seems, isn't that likely to be slower and require more memory?
There was a problem hiding this comment.
Class loaders are cached internally by sbt, based on the jars file. Here we use the compiler jars from the base Scala Instance, so the new compiler class loader should be the same instance.
There was a problem hiding this comment.
Actually there is something wrong with the list of compiler jars, so I will fix it and add an assert to ensure that the class loaders are the same.
There was a problem hiding this comment.
The problem is https://github.com/sbt/sbt/blob/fabeed222799efcc46be15bccf2c31e384f7e369/main/src/main/scala/sbt/Defaults.scala#L1186-L1187
It's like a snake biting it's own tail...
and stop using sbt private
extendedClassLoaderCache