Avoid assertion failure when forcing LazyRef while printing #12653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes scala#12650 The fix that matters for scala#12650 is the one in Checking. The others generally increase robustness of printing diagnostics when triggering a LazyRef recursion.
|
I can review this, let me know when the PR is ready for review. |
|
ready for review |
abgruszecki
approved these changes
Jun 3, 2021
There was a problem hiding this comment.
The code LGTM.
However, the snippet from the linked issue was supposed to demonstrate an issue that @Linyxus discovered when working on GADTs. That issue involved a type from our test suite that looked like this:
trait FooBase {
type This <: FooBase { type This <: FooBase.this.This }
}
Shouldn't this type also be considered cyclic?
trait FooBase {
type This <: FooBase { type This <: FooBase.this.This }
}No, direct recursion in a type member is OK. It's the |
🤔 🙏 more simple example trait StandaloneWSRequest {
type Self <: StandaloneWSRequest {
type Self <: StandaloneWSRequest.this.Self
}
def foo: Self
def bar: Self
}
object Main {
def client: StandaloneWSRequest = null
def main(args: Array[String]): Unit = {
client.foo.bar.foo // error
}
} |
|
@xuwei-k can you open a separate issue for that, and include the stack trace? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12650
The fix that matters for #12650 is the one in Checking. The others generally increase
robustness of printing diagnostics when triggering a LazyRef recursion.