Skip to content

Fix #7635: Package REPL wrappers #12607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 31, 2021
Merged

Conversation

griggt
Copy link
Contributor

@griggt griggt commented May 26, 2021

Fixes #7635 (only the original complaint)

griggt added 2 commits May 25, 2021 21:35
Prior to this commit, the REPL wrapper objects were placed directly
in the empty package. This prevented definitions in the REPL session
from shadowing definitions in the empty package on the classpath
(e.g. from stray .class files in the current directory).
@griggt griggt marked this pull request as ready for review May 26, 2021 07:02
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @griggt 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

REPL should prefer REPL products
3 participants