support xs @ _* and _* in Scala2 mode
#1179
Merged
+54
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1282,6 +1287,12 @@ object Parsers { | |||
|
|
|||
| /* -------- PATTERNS ------------------------------------------- */ | |||
|
|
|||
| def scala2WildcardStarMessage1 = | |||
There was a problem hiding this comment.
I'd refactor a little bit differently.
-
Introduce a method
def migrationWarningOrError(msg: String, pos: Int) = ... -
Drop the message defs here
|
Otherwise LGTM |
The standard syntax in Dotty now is `xs : _*`. In Scala2 mode,
following code should be valid:
list match {
case List(_, _, _, _ @ _*) => 0
case List(_, _, _*) => 1
case List(_, _: _*) => 2
case Nil => 3
}
|
Now I've refined the PR. |
|
LGTM |
odersky
added a commit
that referenced
this pull request
Mar 18, 2016
support `xs @ _*` and `_*` in Scala2 mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1059
The standard syntax in Dotty now is
xs : _*. In Scala2 mode,following code should be valid: