Skip to content

make variable name consistent in ScalaSettings #1173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2016
Merged

make variable name consistent in ScalaSettings #1173

merged 1 commit into from
Mar 14, 2016

Conversation

liufengyun
Copy link
Contributor

Options with syntax "-Y" should NOT be named with a variable beginning with X.

Actually following setting variables are not used in current dotty. If there's no plan to support them in the future, it makes more sense to just remove them.

Options with syntax "-Y" should NOT be named with a variable beginning with `X`.
@DarkDimius
Copy link
Contributor

LGTM.

If there's no plan to support them in the future, it makes more sense to just remove them.

AFAIK, All of those options except Yshowtrees we are not planning to implement, at least in the near future. Feel free to remove them,

DarkDimius added a commit that referenced this pull request Mar 14, 2016
make variable name consistent in ScalaSettings
@DarkDimius DarkDimius merged commit 802de86 into scala:master Mar 14, 2016
@liufengyun
Copy link
Contributor Author

Thanks @DarkDimius . Actually I see there are a lot of unimplemented options. I'll send a new pull request to clean up all unimplemented options (except those planned).

@liufengyun liufengyun deleted the naming-cleanup branch March 14, 2016 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants