Skip to content

Cleanup utest macro implementation #11585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2021

Conversation

nicolasstucki
Copy link
Contributor

No description provided.

@nicolasstucki nicolasstucki marked this pull request as ready for review March 3, 2021 19:58
@nicolasstucki nicolasstucki requested a review from liufengyun March 3, 2021 19:58
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Is the motivation to avoid capturing of Quotes?

@nicolasstucki
Copy link
Contributor Author

nicolasstucki commented Mar 4, 2021

It is just an antipattern that leads to use of Term instead of Expr. It also introduces some additional complications when doing the inference of QCtx. If it does not infere the precise one the errors the user gets are hard to understand.

It also makes that abstraction non-contextual which breaks if you use it within a splice with a different context.

@nicolasstucki nicolasstucki merged commit 5e0100d into scala:master Mar 4, 2021
@nicolasstucki nicolasstucki deleted the clenup-utest-macro branch March 4, 2021 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants