Add support for anchors to old scaladoc and javadoc #11564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pikinier20
force-pushed
the
external-location-anchors
branch
from
7a3f839 to
ac6acf7
Compare
romanowski
requested changes
Mar 1, 2021
| private def transformType(tpe: TypeRepr): String = tpe.simplified match { | ||
| case AppliedType(tpe, typeList) if tpe.show == "scala.Array" => transformType(typeList.head) + ":A" | ||
| case AppliedType(tpe, typeList) if tpe.show == "scala.<repeated>" => transformType(typeList.head) + "..." | ||
| case AppliedType(tpe, typeList) => transformPrimitiveType(tpe.show) |
There was a problem hiding this comment.
Can we compare symbols or types here? Output of show is not guaranteed to be stable.
| import q.reflect._ | ||
| import dotty.tools.dotc | ||
| given ctx: dotc.core.Contexts.Context = q.asInstanceOf[scala.quoted.runtime.impl.QuotesImpl].ctx | ||
| val csym = sym.asInstanceOf[dotc.core.Symbols.Symbol] | ||
| Option(csym.associatedFile).fold("")(_.path) | ||
| Option(csym.associatedFile).map(_.path).flatMap( path => |
There was a problem hiding this comment.
Did you notice any slowdown after these changes? especially this line may affect performance so we may consider caching (this needs to be tested with scala 3 doc not, the self one)
| val originPath = { | ||
| val className = sym.className | ||
|
|
||
| val location = className.fold(sym.packageName)(cn => s"${sym.packageName}.${cn}") |
There was a problem hiding this comment.
I think we can work with Seq[Sring] rather then concatenate and then split it later on in each branch
pikinier20
force-pushed
the
external-location-anchors
branch
from
e82ffcd to
d60bf45
Compare
romanowski
approved these changes
Mar 4, 2021
BarkingBad
approved these changes
Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #11085