Make it possible to always set the prefix of denotations #11330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odersky
approved these changes
Feb 6, 2021
|
test performance please |
The comment above `derived` used to say "Currently this fails bootstrap", this was fixed by scala#11303, and this commit takes care of updating the few places where we were assuming that something had to be a SymDenotation when it didn't. Nevertheless, we still keep essentially the same behavior of reusing denotations that existed before this commit for performance reason, but this is now toggleable using `Config.reuseSymDenotations`. There's one difference with what we did before: if we need to create a new denotation anyway because the info changed, then we always update the prefix at the same time, this doesn't cost us anything and means that we can rely on `prefix` being correctly set on non-sym denotations.
smarter
force-pushed
the
reuseSymDenotations
branch
from
9254c5a to
4cbe9c8
Compare
|
performance test scheduled: 7 job(s) in queue, 1 running. |
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/11330/ to see the changes. Benchmarks is based on merging with master (a63b1d1) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comment above
derivedused to say "Currently this failsbootstrap", this was fixed by #11303, and this commit takes care of
updating the few places where we were assuming that something had to be
a SymDenotation when it didn't. Nevertheless, we still keep essentially
the same behavior of reusing denotations that existed before this commit
for performance reason, but this is now toggleable using
Config.reuseSymDenotations.There's one difference with what we did before: if we need to create a
new denotation anyway because the info changed, then we always update
the prefix at the same time, this doesn't cost us anything and means
that we can rely on
prefixbeing correctly set on non-sym denotations.