Migrate away from dokka: Part 1 #11183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanowski
force-pushed
the
scala3doc/html-rendering
branch
from
aa3926c to
73f46e8
Compare
BarkingBad
approved these changes
Jan 25, 2021
| import HTML._ | ||
|
|
||
| // TODO be more clever about writting - make it much faster! | ||
| trait Writter(using ctx: DocContext) extends Locations: |
There was a problem hiding this comment.
Is it intentional to have double t in Writter, or is it typo?
romanowski
force-pushed
the
scala3doc/html-rendering
branch
4 times, most recently
from
9a949c4 to
8b3e8a7
Compare
BarkingBad
suggested changes
Jan 27, 2021
|
|
||
| extension[T] (member: Member) | ||
| def asLink: LinkToType = LinkToType(member.signature, member.dri, member.kind) | ||
| def deprecated: Option[Annotation] = |
There was a problem hiding this comment.
This will probably conflict with that PR #11216 Though I can resolve conflicts on my own
| import HTML._ | ||
|
|
||
| // TODO be more clever about writting - make it much faster! | ||
| trait Writer(using ctx: DocContext) extends Locations: |
There was a problem hiding this comment.
Still there is typo in filename :P
| @@ -60,6 +60,8 @@ object HTML: | |||
| val h2 = Tag("h2") | |||
| val h3 = Tag("h3") | |||
| val h4 = Tag("h4") | |||
| val h5 = Tag("h4") | |||
| @@ -60,6 +60,8 @@ object HTML: | |||
| val h2 = Tag("h2") | |||
| val h3 = Tag("h3") | |||
| val h4 = Tag("h4") | |||
| val h5 = Tag("h4") | |||
| val h6 = Tag("h4") | |||
pikinier20
reviewed
Jan 28, 2021
Comment on lines
+34
to
+35
| .membersBy(m => m.kind == Kind.Package || m.kind.isInstanceOf[Classlike]) | ||
| .filter(m => m.origin == Origin.RegularlyDefined && m.inheritedFrom.isEmpty) |
There was a problem hiding this comment.
There was a function that decided whether to render page for member or not (Kind.Package and Kind.Classlike can be nested in e.g. Kind.Given). Without checking nested kinds we don't generate pages for all members that should have page.
It should look like
def filterFunc(kind: Kind): Boolean = kind match {
case Kind.Package => true
case _ if kind.isInstanceOf[Classlike] => true
case Kind.Given(inner, _, _) => filterFunc(inner)
case Kind.EnumCase(inner) => filterFunc(inner)
case _ => false
}
val childrenPages = member
.membersBy(m => filterFunc(m.kind))
.filter(m => m.origin == Origin.RegularlyDefined && m.inheritedFrom.isEmpty)
This is huge and scarry commit
Remove rest of dokka usages
FIx some test failures
- Cache dri -> path transformations - compute graphs on demand not on initialization - change writter to writer
romanowski
force-pushed
the
scala3doc/html-rendering
branch
from
3239521 to
81f6a24
Compare
BarkingBad
approved these changes
Jan 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.