Skip to content

Remove reflectedFields macro #11145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 18, 2021
Merged

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Jan 18, 2021

This macro is problematic because the community buid can be compiled on the non-bootstrapped library.

Fixes #11076

@liufengyun
Copy link
Contributor

This macro is problematic because the community build can be compiled on the non-bootstrapped library.

What is the problem with the non-bootstrapped library? Won't macros still work in that context?

@nicolasstucki
Copy link
Contributor Author

Macros may not work properly if we change something from one version to the other. Also, if we change the TASTy version number we might be executing code that expects a different version. I hit one of those issues in #11074 which made it impossible to compile the community-build project.

This macro is problematic because the community buid can be compiled on the non-bootstrapped library.
@liufengyun
Copy link
Contributor

Macros may not work properly if we change something from one version to the other. Also, if we change the TASTy version number we might be executing code that expects a different version. I hit one of those issues in #11074 which made it impossible to compile the community-build project.

Thanks for the detailed explanation. So the rule to follow is: don't use macros in any sub-projects of Dotty, due to bootstrapping problems.

@nicolasstucki
Copy link
Contributor Author

Don't use macros on sub-projects that use the non-bootstrapped compiler. Some projects only compile with the bootstrapped compiler and in those it is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

community-docs CI is using the non-bootstrapped library
3 participants