-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Update metaprogramming docs #11033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update metaprogramming docs #11033
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is your motivation of calling it "Quote reflection" and not just "reflection"? I find it a bit confusing since I understand quotation as a mechanism to turn programs into trees, but we do not reflect on the mechanism, but ob the trees themselves.
I added the |
Ok, thanks for the explanation. So the point is runtime reflection vs. compiletime reflection, right? |
Renaming might also conflict with PR #10932, so maybe we want to merge that one first? |
50d8896
to
46c9644
Compare
Just to get another opinition, @liufengyun what do you think? |
Reflection seems to be simpler and clearer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While Quote Reflection
can work as well, I find the single word Reflection
is already clear enough, adding Quote
does not seem to add more useful meaning to it. Maybe for simplicity just use Reflection
.
eb7cc9a
to
a6fedfa
Compare
Updated |
[skip test]
[skip test_windows_fast]
[skip community_build]