Skip to content

Update metaprogramming docs #11033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nicolasstucki
Copy link
Contributor

[skip test]
[skip test_windows_fast]
[skip community_build]

Copy link
Contributor

@b-studios b-studios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is your motivation of calling it "Quote reflection" and not just "reflection"? I find it a bit confusing since I understand quotation as a mechanism to turn programs into trees, but we do not reflect on the mechanism, but ob the trees themselves.

@nicolasstucki
Copy link
Contributor Author

I added the Quote in Quote Reflection to distinguish it from scala.reflect and hint at the fact that the reflection is inside the Quotes (i.e. quotes.reflect). I'm fine with Reflection if that is clearer to others.

@b-studios
Copy link
Contributor

Ok, thanks for the explanation. So the point is runtime reflection vs. compiletime reflection, right?

@b-studios
Copy link
Contributor

Renaming might also conflict with PR #10932, so maybe we want to merge that one first?

@nicolasstucki nicolasstucki force-pushed the update-metaprogramming-docs branch from 50d8896 to 46c9644 Compare January 8, 2021 12:33
@nicolasstucki
Copy link
Contributor Author

Merged and rebased over #10932. Also fixed the Accumulator issue noticed in #10932.

@b-studios
Copy link
Contributor

I'm fine with Reflection if that is clearer to others.

Just to get another opinition, @liufengyun what do you think?

@liufengyun
Copy link
Contributor

I'm fine with Reflection if that is clearer to others.

Just to get another opinion, @liufengyun what do you think?

Reflection seems to be simpler and clearer.

Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While Quote Reflection can work as well, I find the single word Reflection is already clear enough, adding Quote does not seem to add more useful meaning to it. Maybe for simplicity just use Reflection.

@nicolasstucki nicolasstucki force-pushed the update-metaprogramming-docs branch from eb7cc9a to a6fedfa Compare January 12, 2021 16:11
@nicolasstucki
Copy link
Contributor Author

Updated Quote Reflection to Reflection

@nicolasstucki nicolasstucki merged commit ae9cf23 into scala:master Jan 14, 2021
@nicolasstucki nicolasstucki deleted the update-metaprogramming-docs branch January 14, 2021 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants