Skip to content

Scala3doc: cook comments #10506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 27, 2020
Merged

Conversation

abgruszecki
Copy link
Contributor

Resolve @define-s and expand @inheritdoc-s.

Resolve @define-s and expand @inheritdoc-s.
@abgruszecki
Copy link
Contributor Author

There are still problems with some definitions in the standard library. The issue is that we don't correctly attach the comment to some trees. I'll fix this in a separate PR.

@abgruszecki
Copy link
Contributor Author

All issues with attaching comments are now fixed, all missing variable warnings when documenting stdlib are genuine.

@abgruszecki abgruszecki force-pushed the resolve-doc-variables branch from 4f3dc85 to 9f27fde Compare November 26, 2020 18:25
@abgruszecki
Copy link
Contributor Author

@odersky I needed to modify the scanner to attach docstrings in some cases where it not attach them before. Can you quickly review 60a8b72 (and only that commit)?

@abgruszecki abgruszecki requested a review from odersky November 26, 2020 18:27
@romanowski romanowski merged commit 8819843 into scala:master Nov 27, 2020
@romanowski romanowski deleted the resolve-doc-variables branch November 27, 2020 13:00
@romanowski
Copy link
Contributor

I was a bit merge-happy here, sorry. I can revert this merge or apply fixes if changes in parser needs them.
cc @odersky

@Kordyjan Kordyjan added this to the 3.0.0 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants