Remove reflect refinement form nested quotes #10456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We could refine this type in a later version which would only allow more programs to type check. |
liufengyun
approved these changes
Nov 23, 2020
| val reflect: self.reflect.type | ||
| } | ||
| /** Type of a QuoteContext provided by a splice within a quote that took this context. */ | ||
| type Nested = QuoteContext |
There was a problem hiding this comment.
If this is the case, it seems we can remove this concept?
There was a problem hiding this comment.
I considered it. But if we leave it we can add support for some of those features in a future release. I will look into it later.
nicolasstucki
force-pushed
the
remove-reflection-refinement-from-quotes
branch
3 times, most recently
from
555555f to
2eb4f6a
Compare
This refinement is unsound as the nested `reflect` is not the same as the outer one.
In theory we could make it work by using the refinement
```
type Nested = Quotes {
type Tree >: self.reflect.Tree
...
}
```
This refinement is unfortunately too large for the compiler to handle.
Removing the refinement forces us to transform trees into `Expr` before using them in a splice. This is in general a better practice anyway.
nicolasstucki
force-pushed
the
remove-reflection-refinement-from-quotes
branch
from
2eb4f6a to
5adfd3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refinement is unsound as the nested
reflectis not the same as the outer one.In theory we could make it work by using the refinement
This refinement is unfortunately too large for the compiler to handle.
Removing the refinement forces us to transform trees into
Exprbefore using them in a splice. This is in general a better practice anyway.